ENG-1927 Debounce canvas color writes and flush pending writes on unmount#1144
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90d5792843
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
… timing and remove unused flush function
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c0e378e91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Motivation
Description
COLOR_WRITE_DEBOUNCE_MS, aPendingColorWritetype, and awriteColorSettinghelper to centralize color persistence logic.useRefhooks (colorWriteTimeoutRefandpendingColorWriteRef) and utility functionsclearColorWriteTimeout,persistColor, andpersistColorAfterPauseto debounce writes and manage pending state.persistColorAfterPauseand updated the clear (Iconclick) handler to clear the timeout and callpersistColorfor immediate persistence.useEffectto flush any pending color write on unmount.Testing
tsc/ linter) and they passed.Codex Task